Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix itinerary grouping #976

Merged
merged 13 commits into from
Aug 30, 2023
Merged

Fix itinerary grouping #976

merged 13 commits into from
Aug 30, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

This PR fixes itinerary grouping as follows:

  • Alternate routes are shown regardless of order in which itineraries are received
  • The correct itinerary is shown on the map according to the itinerary shown in the main pane.

PR Checklist

  • [na] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [na] Are all languages supported (Internationalization/Localization)?
  • [na] Are appropriate Typescript types implemented?

amy-corson-ibigroup
amy-corson-ibigroup approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@binh-dam-ibigroup
Copy link
Collaborator Author

Note that in some cases, itineraries may be returned in a different order from one session to another, that is handled in #981.

@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as draft August 23, 2023 17:53
@binh-dam-ibigroup
Copy link
Collaborator Author

Taking this back to draft and reassigning myself. This PR broke the itinerary sorting!

@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as ready for review August 23, 2023 20:14
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great! Thanks so much for all these fixed

@miles-grant-ibigroup miles-grant-ibigroup removed their assignment Aug 30, 2023
@binh-dam-ibigroup binh-dam-ibigroup merged commit 6b3145c into dev Aug 30, 2023
5 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-itin-grouping branch August 30, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @miles-grant-ibigroup @amy-corson-ibigroup